feat: Factorise add to my drive action. #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
changed the base branch from
master
to
externalLinks-famousLastFivePercent
6 tasks
adrien-coye
force-pushed
the
externalLinks-addToMyDriveCellAction
branch
from
9422c9f to
abd2bae
Compare
…alLinks-addToMyDriveCellAction
adrien-coye
force-pushed
the
externalLinks-famousLastFivePercent
branch
from
691feee to
b2f40c3
Compare
…alLinks-addToMyDriveCellAction
…alLinks-addToMyDriveCellAction
…alLinks-addToMyDriveCellAction
…alLinks-addToMyDriveCellAction
adrien-coye
changed the title
adrien-coye
commented
Jan 8, 2025
| @@ -520,4 +522,30 @@ extension FileActionsFloatingPanelViewController { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private func addToMyDrive() { | |||
| guard accountManager.currentAccount != nil else { | |||
There was a problem hiding this comment.
I'm open to expose a new Bool in AccountManager to abstract if any user is authenticated or not.
Checking directly the array here is breaking encapsulation IMO.
| import kDriveCore | ||
| import UIKit | ||
|
|
||
| struct PublicShareAction { |
There was a problem hiding this comment.
I needed to factorise something used between VCs and viewModels, thus created this adhoc type, open to put it somewhere else.
| saveViewController.onDismissViewController = { [weak self] in | ||
| guard let self else { return } | ||
| self.onDismissViewController?() | ||
| if publicShareProxy.fileId != rootProxy.id, selectedItemsIds.isEmpty { |
There was a problem hiding this comment.
The API doc does not cover this logic, yet I did not add a comment per our rules
…alLinks-addToMyDriveCellAction
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small branch lives on top of the "add to my drive" branch.